NSP GK4 v3.3 Bug?

Hi There!

Just testing NSPGK4 v3.3 using Bikestore template v3.4, I think the module got updated and Gavick developers added on line 111 of layout.parts.php:

Code: Select all

if($config['img_margin'] != '') $margins = ' style="margin:'.$config['img_margin'].';"';

and the above code is being called in line 114 as an inline style for the image link. But this causes the images in Portal Mode News Gallery (Responsive) to not showing the exact size as set in the module thumbnail configuration. This margin will push the image to the right with whatever value is set in thumbnail margin panel.

I think the padding in div class="nspArt" does the spacing properly which also gets the padding value from the same setting in thumbnail panel.

Code: Select all

<div class="nspArt" style="padding: <?php echo $this->parent->config['img_margin']; ?>;width:<?php echo $this->parent->config['img_width'] + 2; ?>px;">

I don't know why the inline css margin in <a tag was added in v3.3, it was not there in v3.2. Maybe to fix other issues with other mode. May I suggest to just add:

margin

padding

separately to the thumbnail panel separately instead of getting the value from one setting.

Thanks

Hi

Can You please show me a live example of such issue ?

Hi Teitbite,

Sorry for the late reply. You can try it yourself using a default Joomla install + Gavick Template + NSP. You'll see what I'm talking about. That's how I confirmed it was your code.

Thanks!

Hi

I got it already installed, but there are ways to adjust it per template without modification of module's code. Please show me live site where I will be able to see this problem and I'll tell You the code to add in order to fix this issue.