Version 3.18 update buggy

**GK User** Wed Jul 22, 2015 8:33 am

I have updated my site photo template to 3.18 but the upgrade has introduced 2 severe errors.

1. The overrrides.css has been deleted by a blank css, so any customization has been lost.
2. The Site title is replaced by Homepage (title of the first Main Menu item)

Could you fix quickly these bugs or give me access to download the 3.17 ?

Kind regards...Antonio

**GK User** Wed Jul 22, 2015 8:54 am

Hello,

1. Please remember to backup the override.css file before any update or please just store your custom CSS under template settings -> Advanced -> Custom CSS code option

2. In my opinion it is just not possible, because menu structure and joomla configuration cannot be affected by the template update.

**GK User** Wed Jul 22, 2015 9:01 am

I have made a deeper review of the problem with the site title.

I am using only text titles in my site, but after the update the site is trying to use image logo and as there is no image selected it shows the image alt value (Homepage)

Kind regards....Antonio

**GK User** Wed Jul 22, 2015 4:54 pm

The bugs are located in the lines 35 and 37 of the default layout (layout/default.php).

The code adds the base URL path to the image variables ($logo_image and $logo_image_header) without checking if the variable is empty (no image provided).

As these variables aren't empty always try to show the image logo (in my case with an invalid URL)

Although I have fixed my site but I think you should update the template.

Kind regards...Antonio

**GK User** Thu Jul 23, 2015 4:08 pm

Please provide your fix here, because both variables are checked if they are empty.

**GK User** Thu Jul 23, 2015 6:14 pm

Here you have the fix.

layouts/default.php (original)
========================================================
34 $logo_image = $this->API->get('logo_image', '');
35 $logo_image = $this->API->URLbase() . $logo_image;
36 $logo_image_header = $this->API->get('logo_image_header', '');
37 $logo_image_header = $this->API->URLbase() . $logo_image_header;

layouts/default.php (fixed)
========================================================
34 $logo_image = $this->API->get('logo_image', '');
35 if ($logo_image != '') $logo_image = $this->API->URLbase() . $logo_image;
36 $logo_image_header = $this->API->get('logo_image_header', '');
37 if ($logo_imager_header != '') $logo_image_header = $this->API->URLbase() . $logo_image_header;

If you don't do this, these variables never will be empty and will contain at least the value of $this->API->URLbase().

Regards....Antonio

**GK User** Fri Jul 24, 2015 11:39 am

Thank you, now I understand the issue - I will report it to our maintenance team.

**GK User** Thu Aug 13, 2015 6:11 pm

agonzalezrem wrote:Here you have the fix.

layouts/default.php (original)
========================================================
34 $logo_image = $this->API->get('logo_image', '');
35 $logo_image = $this->API->URLbase() . $logo_image;
36 $logo_image_header = $this->API->get('logo_image_header', '');
37 $logo_image_header = $this->API->URLbase() . $logo_image_header;

layouts/default.php (fixed)
========================================================
34 $logo_image = $this->API->get('logo_image', '');
35 if ($logo_image != '') $logo_image = $this->API->URLbase() . $logo_image;
36 $logo_image_header = $this->API->get('logo_image_header', '');
37 if ($logo_imager_header != '') $logo_image_header = $this->API->URLbase() . $logo_image_header;

If you don't do this, these variables never will be empty and will contain at least the value of $this->API->URLbase().

Regards....Antonio

Thanks Antonio for the fix.