cloned 'nsp' class and <p></p> tags

News Show Pro GK5 - flexible, responsive and easily extendable free Joomla module support forum.
Rate this topic: Evaluations: 0, 0.00 on the average.Evaluations: 0, 0.00 on the average.Evaluations: 0, 0.00 on the average.Evaluations: 0, 0.00 on the average.Evaluations: 0, 0.00 on the average.Evaluations: 0, 0.00 on the average.
GK User
Mon Dec 22, 2014 3:57 am
Hello,
My website is only local, not online.

I found that line 26 in modules\mod_news_pro_gk5\tmpl\default.php
Code: Select all
<?php echo ' ' . $this->config['moduleclass_sfx']; ?>

makes the class "nsp" duplicated
that class "nsp" have position:relative so the navigation arrows with absolute position have problem
news show pro gk4 hasn't got that line
when i delete this line, navigation act like gk4 does.

Another thing in line 62 in modules\mod_news_pro_gk5\tmpl\view.php
Code: Select all
<p class="nspText'.$class.'">'.$item['text'].'</p>

when i switch OFF the 'clean HTML code in the text',
the module close the
Code: Select all
<p class="nspText"></p>
and add an empty
Code: Select all
<p></p>
after the html text.
because i think html code like 'ul' or 'li' not allowed inside <p>
things get better when it is :
Code: Select all
<div class="nspText'.$class.'">'.$item['text'].'</div>


Not a big deal but i have to hack the module two times
Maybe i am the only one who need this but i just let you know if you think its important or not.

Thanks
User avatar
Fresh Boarder

teitbite
Mon Dec 22, 2014 3:13 pm
Hi

'nsp' class is neccessary. Module has to be relative por fagination or in some cases paginations from all NSP modules is displayed in right left corner. So a static 'nsp' class was added to prevent that.

I do not quite understand the other issue ;/ Doesn't using the selector ".customclass .nspText" or ".nspText.customclass" to relate to the element makes as much of a difference.
User avatar
Moderator

GK User
Tue Dec 23, 2014 1:31 am
Hello,
My pagination is too low like it is and i have a class nsp before the header and one after :
Code: Select all
<section style="font-size: 100%;" id="gkMainbody">
<div class="box nsp big clear nomargin">
<div>
<h3 class="header"></h3>   
<div class="nspMain  nsp big clear activated" id="nsp-newspro1" data-config="">
<div class="nspArts bottom" style="width:100%;">
<div class="nspTopInterface">

Image

for the other issue is that empty <p></p> have a margin-bottom and margin-top that makes problem
clean html is OFF without modification:
Image
clean html is OFF after modification:
Image

Thanks
User avatar
Fresh Boarder

teitbite
Wed Dec 24, 2014 12:06 pm
Hi

This looks like a validation issue. Please tell me the url to Your site. Have You used a "Clean HTML" option? It's a must if You are cutting the text to a specific number of chars/words.
User avatar
Moderator

GK User
Sat Dec 27, 2014 10:10 pm
Hi,
I have no issue, everything is good now.
Thanks for your time
User avatar
Fresh Boarder

teitbite
Sun Dec 28, 2014 11:42 am
Hi

I'm glad to hear it :) Thank You for the information.
User avatar
Moderator


cron