Image dimensions not specified

I am using GK News Show Pro. It generates thumbnails for which image dimensions are not specified. Google recommends that image dimensions should be specified. Any solution for this?

Hi,

In the gavern/widgets.nsp.php you have to find function generate_art_image and change line:

Code: Select all

return '<a href="'.$art_url.'" class="gk-responsive gk-image-link" '.$style.'><img src="'.$new_path.'" alt="" class="gk-nsp-image gk-responsive" /></a>';

to:

Code: Select all

return '<a href="'.$art_url.'" class="gk-responsive gk-image-link" '.$style.'><img src="'.$new_path.'" alt="" class="gk-nsp-image gk-responsive" height="'.$this->wdgt_config['article_image_h'].'px" width="'.$this->wdgt_config['article_image_w'].'px" /></a>';

Not working, may be because the widget shows cached images

like this url http://mysite.com/wp-content/themes/New ... _nsp-6.jpg

Sorry I forgot to add these attributes in the second place, please replace:

Code: Select all

if($this->wdgt_config['article_image_pos'] == 'left' && $this->wdgt_config['article_image_order'] == 1) {
             return '<div class="gk-nsp-image-wrap"><a href="'.$art_url.'" class="gk-image-link" '.$style.'><img src="'.$new_path.'" alt="" class="gk-nsp-image" height="'.$this->wdgt_config['article_image_h'].'px" width="'.$this->wdgt_config['article_image_w'].'px" /></a></div>';
          } else {
             return '<a href="'.$art_url.'" class="gk-responsive gk-image-link" '.$style.'><img src="'.$new_path.'" alt="" class="gk-nsp-image gk-responsive" height="'.$this->wdgt_config['article_image_h'].'px" width="'.$this->wdgt_config['article_image_w'].'px" /></a>';
          }

with:

Code: Select all

if($this->wdgt_config['article_image_pos'] == 'left' && $this->wdgt_config['article_image_order'] == 1) {
    return '<div class="gk-nsp-image-wrap"><a href="'.$art_url.'" class="gk-image-link" '.$style.'><img src="'.$new_path.'" alt="" class="gk-nsp-image" /></a></div>';
 } else {
    return '<a href="'.$art_url.'" class="gk-responsive gk-image-link" '.$style.'><img src="'.$new_path.'" alt="" class="gk-nsp-image gk-responsive" /></a>';
 }


I can't find this code anywhere in the file.

The code at the bottom should be the one that should be replaced and not the one at the top.
Also doing that gives 500 internal server error.

Please just use the attached file

Thanks it worked. However, I am using 4 News Show Pro Widgets on my website and it is working for only one plugin and not for all.

Please re-save the configuration of the rest of the widgets.

Hi dziudek,
I just wonder why you haven't integrated this fix in the february update, and the ticket is still open in GitHub. Do you want me to fix it and send you a pull request?

Regards,
Thomas.

@tbarthelet - most probably the v.1.6 was frozen, that's why I've added it to the v.1.7 ToDo, I've merged your pull request

This issue is happening again with News v1.4

I don't know why it wasn't added, I'll report this topic to the developer who maintenance our themes.